fix: Fix pyright type checks on benchmark directory #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/pyright-benchmarking
…nchmarking branch #912
qh681248
changed the base branch from
main
to
feature/add-kernel-thinning-to-benchmarking
qh681248
changed the base branch from
feature/add-kernel-thinning-to-benchmarking
to
main
|
Blocked by #927 as this contains the commits from that PR as well. (Either wait for that PR to be merged, or rebase the commits unique to this PR onto |
|
Replaced by #942 as this PR contains too many commits from different branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#912
PR Type
Description
Static type check fixes
How Has This Been Tested?
Existing tests pass as expected.
Pyright passes on benchmark directory with 0 warnings, 0 errors and 0 informations.
Does this PR introduce a breaking change?
Checklist before requesting a review