Skip to content

Commit

Permalink
Merge pull request #4738 from gchq/gh-4719
Browse files Browse the repository at this point in the history
#4719 Fix duplicate pipeline dependencies per user due to multiple pr…
  • Loading branch information
stroomdev66 authored Jan 28, 2025
2 parents 4ac0895 + df05489 commit 8bc468d
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ public List<UserDependency> getUserDependencies(final UserRef userRef) {
// userDependency.getDocRef(),
// docRef -> securityContext.hasDocumentPermission(docRef, DocumentPermission.VIEW),
// true))
.distinct()
.toList();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@ public boolean equals(final Object object) {
return false;
}
final UserDependency that = (UserDependency) object;
return Objects.equals(userRef, that.userRef) && Objects.equals(details,
that.details) && Objects.equals(docRef, that.docRef);
return Objects.equals(userRef, that.userRef) &&
Objects.equals(details, that.details) &&
Objects.equals(docRef, that.docRef);
}

@Override
Expand Down
24 changes: 24 additions & 0 deletions unreleased_changes/20250128_163205_829__4719.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
* Issue **#4719** : Fix duplicate pipeline dependencies per user due to multiple processor filters.


```sh
# ********************************************************************************
# Issue title: User: Dependencies get visually confused by multiple Proc Filters for a Processor
# Issue link: https://github.com/gchq/stroom/issues/4719
# ********************************************************************************

# ONLY the top line will be included as a change entry in the CHANGELOG.
# The entry should be in GitHub flavour markdown and should be written on a SINGLE
# line with no hard breaks. You can have multiple change files for a single GitHub issue.
# The entry should be written in the imperative mood, i.e. 'Fix nasty bug' rather than
# 'Fixed nasty bug'.
#
# Examples of acceptable entries are:
#
#
# * Issue **123** : Fix bug with an associated GitHub issue in this repository
#
# * Issue **namespace/other-repo#456** : Fix bug with an associated GitHub issue in another repository
#
# * Fix bug with no associated GitHub issue.
```

0 comments on commit 8bc468d

Please sign in to comment.