Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4719 Fix duplicate pipeline dependencies per user due to multiple pr… #4738

Merged
merged 1 commit into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ public List<UserDependency> getUserDependencies(final UserRef userRef) {
// userDependency.getDocRef(),
// docRef -> securityContext.hasDocumentPermission(docRef, DocumentPermission.VIEW),
// true))
.distinct()
.toList();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@ public boolean equals(final Object object) {
return false;
}
final UserDependency that = (UserDependency) object;
return Objects.equals(userRef, that.userRef) && Objects.equals(details,
that.details) && Objects.equals(docRef, that.docRef);
return Objects.equals(userRef, that.userRef) &&
Objects.equals(details, that.details) &&
Objects.equals(docRef, that.docRef);
}

@Override
Expand Down
24 changes: 24 additions & 0 deletions unreleased_changes/20250128_163205_829__4719.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
* Issue **#4719** : Fix duplicate pipeline dependencies per user due to multiple processor filters.


```sh
# ********************************************************************************
# Issue title: User: Dependencies get visually confused by multiple Proc Filters for a Processor
# Issue link: https://github.com/gchq/stroom/issues/4719
# ********************************************************************************

# ONLY the top line will be included as a change entry in the CHANGELOG.
# The entry should be in GitHub flavour markdown and should be written on a SINGLE
# line with no hard breaks. You can have multiple change files for a single GitHub issue.
# The entry should be written in the imperative mood, i.e. 'Fix nasty bug' rather than
# 'Fixed nasty bug'.
#
# Examples of acceptable entries are:
#
#
# * Issue **123** : Fix bug with an associated GitHub issue in this repository
#
# * Issue **namespace/other-repo#456** : Fix bug with an associated GitHub issue in another repository
#
# * Fix bug with no associated GitHub issue.
```