server-side otsu #13
Open
server-side otsu #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gena
reviewed
Apr 1, 2022
Collaborator
gena
left a comment
gena
left a comment
There was a problem hiding this comment.
I guess these were needed to move some argument passing server-side? Should I update the JavaScript package/ correspondingly, maybe let's quickly chat about how to keep these in sync as this is being done manually.
Collaborator
Author
|
I know that geemap has some conversion system converting from JavaScript. But of course, collaboration on EarthEngine code is more difficult, as it does not seem to support Pull Requests, branches etc. Let's have a chat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to generate Otsu threshold server side, to make sure I can map over reservoirs server side.
@gena please check this code, I used
ee.Algorithms.Ifto do the argument checking. I am not exactly sure how that works on the earthengine side, but I have not noticed a longer computation time.