common.py: Cleanup 2025-12-31 #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move import webbrowser and box to the top * Remove redundant imports of requests * Add more type annotations * Remove types from doc strings when type annotations are present * Fit to 88 columns * Convert doc strings to start with "Returns" and remove "Returns:" section * Remove commented out code * Remove redundant comments * Add missing puctuation to comment
* Remove types from doc strings with type annotations are present * Add missing punctation in comments * Fix typo `avariables` * Add type annotations * Remove commented out code * Simplify `get_current_year` * `find_files`: * Switch `Path` to pathlib.Path * Make a local variable `path` for `Path(input_dir)` * `(x, y)` --> `x, y` when the parens are not required * Remove `:param:` in doc string for `get_geometry_coords` * Remove extra blank lines * Remove redundant comments * Start doc string summary line directly after `"""` * Add `assert parent` for `psutil.Process().parent()` for pytype * Avoid a local bool variable when just returning a bool * `hex_to_rgba`: Improve doc string * `remove_port_from_string`: Remove `result = ` when just returning result * `pmtiles_style`: Remove extra kwargs * Use module import: `get_palette` --> `colormaps.get_palette` * Use `pathlib.Path.read()`
* import colormaps * ipywidgets is aliased to widgets
jdbcode
reviewed
Jan 8, 2026
jdbcode
approved these changes
Jan 8, 2026
Member
jdbcode
left a comment
jdbcode
left a comment
There was a problem hiding this comment.
Preemptive LGTM, see comment about being able to remove a possibly unused import.
Collaborator
Author
|
I will try to figure out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #2437