test_common.py: Add more tests #2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
list_vars, display_html, get_direct_url, html_to_gradio, landsat_scaling test_check_dir: Add a check for an invalid type.
naschmitz
approved these changes
Jan 6, 2026
tests/test_common.py
Outdated
| self.assertTrue(os.path.exists(abs_path_2)) | ||
| self.assertEqual(abs_path_2, os.path.abspath(dir_path_2)) | ||
|
|
||
| # Test with invalid type |
Collaborator
There was a problem hiding this comment.
Minor nit: Most of the comments in geemap end with a period. The comments in this file don't.
Collaborator
Author
There was a problem hiding this comment.
Bugger. Thanks for point it out. I fixed the entire file. I think gemini saw that most of the comments in geemap don't have punctuation, so it was continuing the trend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list_vars,display_html,get_direct_url,html_to_gradio,landsat_scalingtest_check_dir: Add a check for an invalid type.