feat: use ansible_facts rather than variables

[jackhodgkiss]

This PR addresses the issue raised in #422 by replacing ansible_ with ansible_facts. counterparts.

Has been tested numerous times within Ubuntu 22.04.

[markgoddard]

LGTM

[geerlingguy]

Seems like there's a merge conflict—happy to merge once that's fixed up!

[jackhodgkiss]

Merge conflict resolved.

[markgoddard]

How's this looking now @geerlingguy?

[github-actions]

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

[markgoddard]

@geerlingguy please could you merge this one? Thanks

[github-actions]

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

[markgoddard]

:(

[jamesmyatt]

@geerlingguy , looks like this has been ready for a year. Any chance of merging it?

[geerlingguy]

@jamesmyatt - Only reason I haven't merged is I wanted to take some time and update this across all my roles at once, for consistency... still might do that, or go ahead and merge in some roles sooner, we'll see.

It doesn't really harm the roles to use the old way though.

[jamesmyatt]

Makes sense. Thank you.

[jonasc]

It doesn't really harm the roles to use the old way though.

Hey just wanted to chime in, that I came across this issue as well after disabling INJECT_FACTS_AS_VARS due to security concerns when used when bulk-setting task arguments. I made the changes locally, but I'd be happy if this could merged.

Thank you for the great ansible roles!