-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: Allow default vhost path override #245
base: master
Are you sure you want to change the base?
Conversation
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
vars/FreeBSD.yml
Outdated
@@ -5,5 +5,5 @@ nginx_conf_file_path: /usr/local/etc/nginx/nginx.conf | |||
nginx_mime_file_path: /usr/local/etc/nginx/mime.types | |||
nginx_pidfile: /var/run/nginx.pid | |||
nginx_vhost_path: /usr/local/etc/nginx/sites-enabled | |||
nginx_default_vhost_path: /usr/local/etc/nginx/sites-enabled/default | |||
nginx_default_vhost_path: "{{ nginx_override_default_vhost_path | default('/usr/local/etc/nginx/sites-enabled/default') }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Actions
/ Lint
8:121 [line-length] line too long (123 > 120 characters)
nginx_default_vhost_path: "{{ nginx_override_default_vhost_path | default('/usr/local/etc/nginx/sites-enabled/default') }}" | |
nginx_default_vhost_path: > | |
{{ nginx_override_default_vhost_path | | |
default('/usr/local/etc/nginx/sites-enabled/default') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
Allow to use an alternative default vhost filename (to be able to remove it!).
Some distribution and/or package supplier changed the default vhost file over time.
For example in nginx 1.24 Debian package supplied by nginx.org, vhost default file supplied is now '/etc/nginx/conf.d/default.conf' instead of '/etc/nginx/sites-enabled/default' previously.
just set variable nginx_override_default_vhost_path accordingly.
if nginx_override_default_vhost_path is not set nothing changes.