Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Allow default vhost path override #245

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ndf-dw
Copy link

@ndf-dw ndf-dw commented Nov 23, 2023

Allow to use an alternative default vhost filename (to be able to remove it!).

Some distribution and/or package supplier changed the default vhost file over time.

For example in nginx 1.24 Debian package supplied by nginx.org, vhost default file supplied is now '/etc/nginx/conf.d/default.conf' instead of '/etc/nginx/sites-enabled/default' previously.

just set variable nginx_override_default_vhost_path accordingly.

if nginx_override_default_vhost_path is not set nothing changes.

Copy link

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Mar 23, 2024
vars/FreeBSD.yml Outdated
@@ -5,5 +5,5 @@ nginx_conf_file_path: /usr/local/etc/nginx/nginx.conf
nginx_mime_file_path: /usr/local/etc/nginx/mime.types
nginx_pidfile: /var/run/nginx.pid
nginx_vhost_path: /usr/local/etc/nginx/sites-enabled
nginx_default_vhost_path: /usr/local/etc/nginx/sites-enabled/default
nginx_default_vhost_path: "{{ nginx_override_default_vhost_path | default('/usr/local/etc/nginx/sites-enabled/default') }}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions
/ Lint
8:121 [line-length] line too long (123 > 120 characters)
Suggested change
nginx_default_vhost_path: "{{ nginx_override_default_vhost_path | default('/usr/local/etc/nginx/sites-enabled/default') }}"
nginx_default_vhost_path: >
{{ nginx_override_default_vhost_path |
default('/usr/local/etc/nginx/sites-enabled/default') }}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actions github-actions bot removed the stale label Apr 13, 2024
Copy link

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Aug 17, 2024
@github-actions github-actions bot removed the stale label Aug 24, 2024
Copy link

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants