Allow for custom fail2ban.local #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trifisch
reviewed
Sep 25, 2025
|
|
||
| - name: Copy fail2ban custom configuration file into place. | ||
| template: | ||
| src: fail2ban.local.j2 |
There was a problem hiding this comment.
Line src: fail2ban.local.j2 needs to removed. Then it should work.
trifisch
reviewed
Sep 25, 2025
| security_fail2ban_enabled: true | ||
| security_fail2ban_custom_configuration_template: "jail.local.j2" | ||
| security_fail2ban_custom_jail_template: "jail.local.j2" | ||
| security_fail2ban_custom_configuration_template: "fail2ban.local.j2" |
There was a problem hiding this comment.
Technically, the variable name security_fail2ban_custom_configuration_template seems to be good for fail2ban.local. Nevertheless, for backward compatibility it would be better to keep it for the jail.local and create a new variable for the fail2ban.local config.
Proposal:
security_fail2ban_custom_fail2ban_local_template: "fail2ban.local.j2"
security_fail2ban_custom_configuration_template: "jail.local.j2"
In this case only the line
src: fail2ban.local.j2
needs to be changed to
src: "{{ security_fail2ban_custom_fail2ban_local_template }}"
in file tasks/fail2ban.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.