Merged
Conversation
|
@Birdmannn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Kaylahray
approved these changes
Mar 30, 2026
Contributor
Kaylahray
left a comment
There was a problem hiding this comment.
Thank you for contributing 🙋♀️💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Reputation Score
What changed
types.rsDataKey::Reputation(Address)for persistent score storage.profile.rspub(crate) fn increment_reputation(env, user)— a plain Rust function outside#[contractimpl], so it is never exposed in the contract ABI and cannot be called externally.pub fn get_reputation(env, user) -> u64— public read, defaults to 0.giveaway.rsdistribute_prizecallsProfileContract::increment_reputationafter marking the giveawayCompleted, incrementing the creator's score by 1.test.rstest_reputation_starts_at_zero— new address has score 0.test_reputation_increments_after_distribute_prize— score is 1 after a full giveaway cycle.test_reputation_accumulates_across_giveaways— score is 2 after two completed giveaways.Security note
increment_reputationispub(crate)and lives outside#[contractimpl]. The Soroban macro only generates ABI entries for functions inside that block, so there is no on-chain entry point for it. The only code path that can call it isdistribute_prizewithin the same crate.Checklist
npx prisma generateafter schema changesnpx prisma migrate devornpx prisma migrate deployas appropriatePost-Merge Steps for Maintainers
If this PR includes changes to the Prisma schema:
Run the following command to apply the migration to your database:
or, for local development:
Ensure your CI pipeline runs the migration before tests (add this step if missing):
Make sure the database user in CI has permission to run migrations.
If you have any questions, please comment on this PR.
This PR closes #212