Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix Krates/cargo_metadata pairing #521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pinkforest
Copy link
Collaborator

@pinkforest pinkforest commented May 13, 2024

EDIT: Needs work. There are broken abstractions / couplings between krates/geiger/cargo_metadata

The only way to fix it is to upgrade the deps but that leads to a lot of breaking changes between krates / cargo_metadata which are coupled as internal abstractions that are very time consuming to eradicate and / or fix.

The biggest is cargo_metadata::PackageId is not recognised by krates anymore and the previous versions of krates have some unhandled unwrap that is deep down the parser that handles the repr (that comes from the lockfile)

The release from crates.io works fine but transient dependency messed things up for main dev which is pity.

I'll continue untangling the abstractions that are affected by the breakage in order to upgrade to fix.

…rgo/cargo_metadata-0.18.1"

This reverts commit 16adb81, reversing
changes made to d2a98a7.
@pinkforest pinkforest changed the title Revert "Merge pull request #483 from geiger-rs/dependabot/cargo/cargo… Fix Krates/cargo_metadata pairing May 13, 2024
@pinkforest pinkforest changed the title Fix Krates/cargo_metadata pairing WIP: Fix Krates/cargo_metadata pairing May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant