Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a basic show command #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement a basic show command #46

wants to merge 1 commit into from

Conversation

HellRok
Copy link
Collaborator

@HellRok HellRok commented Apr 26, 2019

This is useful for scripting and generating ctags

@HellRok
Implement a basic show command
7d19a43 
This is useful for scripting and generating ctags
@HellRok HellRok requested a review from matthewd April 26, 2019 06:33
@matthewd
Copy link
Member

Apparently Bundler are splitting show into list and info: https://speakerdeck.com/colby/working-towards-bundler-3?slide=91

I think we might as well follow their precedent, and go straight to the new names.

Beyond that: 1) tests please, and 2) how will this behave when run outside a Gemfile-containing project directory / how would we like it to?

@HellRok
Copy link
Collaborator Author

HellRok commented Apr 30, 2019

I'm happy to implement list in this PR and maybe make a new one to do info and I'll add some tests and catch the case when no gemfile is present

I'm thinking it'll print a basic message to stderr and exit 1, what do you think?

Base automatically changed from master to main January 16, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewd matthewd Awaiting requested review from matthewd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HellRok @matthewd