Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZETA-Guard: Fehlerbehebungen im Setup-Skript #32

Closed
wants to merge 2 commits into from
Closed

ZETA-Guard: Fehlerbehebungen im Setup-Skript #32

wants to merge 2 commits into from

Conversation

saschpe
Copy link
Contributor

@saschpe saschpe commented Mar 13, 2025

No description provided.

saschpe added 2 commits March 13, 2025 12:35
@saschpe
ZETA-Guard: Fix typos in setup script
dc859f8
@saschpe
ZETA-Guard: Quote kube context in setup script
c8161f1 
Added quotes around the kubectl context name to handle potential issues
with variable expansion or special characters in the cluster name. This
ensures more robust and error-free script execution.
gem-cp
gem-cp requested changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@gem-cp gem-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die PoC Dateien wurden stark verändert, sodass der PR nicht mehr konfliktfrei ist. Daher bitte neune PR auf dem aktuellen Stand stellen.

@gem-cp
Copy link
Contributor

gem-cp commented Mar 13, 2025

This pull request includes several small changes to the components/ZETA_Guard/setup.sh file to correct typos and improve the clarity of commands.

Typos and command clarity improvements:

  • Corrected a typo in the message about permission denied errors.
  • Added quotes around the context name in the kubectl config use-context command for better command execution.
  • Corrected the message to use the singular form "autoscaler" instead of "autoscalers".

@gem-cp gem-cp closed this Mar 13, 2025
@saschpe saschpe deleted the saschpe.zg-setup-sh-tweaks branch March 14, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gem-cp gem-cp gem-cp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschpe @gem-cp