ci: update evalbench pipeline trigger and add missing scorers - #155
Merged
Conversation
- **Pipeline Alignment:** Updated `cloudbuild.yaml` trigger logic to support the `ci:run-evals` label for non-release branches and set `RELEASE_VERSION` context accordingly. - **Scorers:** Added missing `skills_best_practices` and `skills_trajectory` evaluation scorers to `evals/run_config.yaml`.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new ci:run-evals label and updates the Cloud Build configuration to allow manual triggering of evaluation pipelines on pull requests. It also refines the RELEASE_VERSION logic for non-release branches and adds skills_best_practices and skills_trajectory scorers to the evaluation configuration. Feedback was provided to improve the robustness of the label check in cloudbuild.yaml by using jq for exact matching instead of substring matching to prevent false positives.
…stead of string parsing
Contributor
|
Fix the run |
omkargaikwad23
commented
May 5, 2026
…d region variables
averikitsch
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloudbuild.yamltrigger logic to support theci:run-evalslabel for non-release branches and setRELEASE_VERSIONcontext accordingly.skills_best_practicesandskills_trajectoryevaluation scorers toevals/run_config.yaml.BEGIN_COMMIT_OVERRIDE
ci: update evalbench pipeline trigger and add missing scorers
END_COMMIT_OVERRIDE