Skip to content

fix: resolve failing tests by improving JSDOM mock and mocking DOMPurify #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenhutchison merged 3 commits into from
Nov 14, 2025
Merged

fix: resolve failing tests by improving JSDOM mock and mocking DOMPurify #12

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8088968
fix: resolve failing tests by improving JSDOM mock and mocking DOMPurify
allenhutchison Nov 14, 2025
b029097
Update workspace-mcp-server/src/__tests__/mocks/jsdom.ts
allenhutchison Nov 14, 2025
d33e1a6
fix: improve JSDOM mock robustness based on PR feedback
allenhutchison Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module.exports = {
'^@/(.*)$': '<rootDir>/workspace-mcp-server/src/$1',
'\\.wasm$': '<rootDir>/workspace-mcp-server/src/__tests__/mocks/wasm.js',
'^marked$': '<rootDir>/workspace-mcp-server/src/__tests__/mocks/marked.js',
'^jsdom$': '<rootDir>/workspace-mcp-server/src/__tests__/mocks/jsdom.ts',
},
setupFilesAfterEnv: ['<rootDir>/workspace-mcp-server/src/__tests__/setup.ts'],
collectCoverageFrom: [
Expand Down
127 changes: 45 additions & 82 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@
"dompurify": "^3.1.6",
"google-auth-library": "^10.4.0",
"googleapis": "^166.0.0",
"jsdom": "^27.0.0",
"jsdom": "^27.2.0",
"keytar": "^7.9.0",
"marked": "^16.2.1"
},
"devDependencies": {
"@jest/globals": "^30.0.5",
"@types/dompurify": "^3.0.5",
"@types/jest": "^30.0.0",
"@types/jsdom": "^21.1.7",
"@types/jsdom": "^27.0.0",
"@types/node": "^24.2.1",
"@typescript-eslint/eslint-plugin": "^8.46.4",
"@typescript-eslint/parser": "^8.46.4",
Expand All @@ -58,7 +58,7 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/google-gemini/gemini-cli-workspace.git"
"url": "git+https://github.com/gemini-cli-extensions/workspace.git"
},
"keywords": [
"mcp",
Expand Down
Loading
Loading