Fix packaging for jsdom/keytar and resolve deprecated deps - #19
Conversation
Summary of ChangesHello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the project's packaging and dependency management. It transitions to a more robust method for including critical node_modules like jsdom and keytar in release artifacts, ensuring greater stability. Concurrently, it updates core Google API dependencies and addresses known deprecation warnings, contributing to a healthier and more maintainable dependency tree. The changes also include improvements to build and cleanup scripts, streamlining development and release processes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses dependency issues and improves the packaging process. The updates to dependencies and the use of overrides in package.json successfully resolve deprecation warnings. The new release script logic, which recursively copies dependencies for jsdom and keytar, is a more robust approach than the previous bundling method. I've identified one area for improvement concerning code duplication between two of the scripts, and I've left specific comments with suggestions for refactoring. Overall, these are solid changes that enhance the project's stability and maintainability.
Fix Packaging and Resolve Deprecated Dependencies
Changes
Packaging
scripts/release.js: Updated to recursively copynode_modulesforjsdomandkeytar(and their dependencies) into the release artifact. This replaces the previous bundling approach forjsdomwhich required fragile runtime patches.scripts/release.js: Added logic to copy thecommandsdirectory to the release artifact.package.json: Updatedreleasescript to automatically runnpm run buildbefore packaging. Addedrelease:devfor a full install+build+release cycle.workspace-mcp-server/package.json: Updatedcleanscript to removenode_modules.Dependencies
package.json:@google-apps/chatto^0.21.0.@googleapis/docsto^8.1.1.@googleapis/driveto^19.2.0.google-auth-libraryto^10.5.0.overridesforglob(^10.4.5) andinflight(^1.0.6) to resolve deprecation warnings.scripts/list-deps.js: Added a utility script to list transitive dependencies (moved toscripts/).Other
gemini-extension.json: Updated version toDEVand formatted args for local development.Verification
npm run releasecreates a valid artifact with all necessary dependencies.npm installruns without deprecated dependency warnings (exceptnode-domexceptionwhich is upstream).