Add option to control test repeat execution strategy #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'parallelRepeats' option to control how test repeats are queued: - When true (default): all repeats are queued immediately for parallel execution - When false: repeats are queued one by one after each test completion
zloit
commented
May 6, 2025
DudaGod
reviewed
May 19, 2025
lib/repeat-counter.js
Outdated
| @@ -21,6 +23,9 @@ module.exports = class RepeatCounter { | |||
|
|
|||
| if (repeatsLeft > 0) { | |||
| logger.info(`Will be repeated. Repeats left: ${repeatsLeft}`); | |||
| if (!this._parallelRepeats) { | |||
| this._testplane.addTestToRun(test, test.browserId); | |||
There was a problem hiding this comment.
repeatCounter should not be responsible for repeating tests. It is just a counter.
We should implement additional method in Repeater which will be called if there are additional repeats for ended test.
- RepeatCounter is now only responsible for counting repeats - Repeater handles test repetition logic via new handleTestEnd() method - Updated documentation for parallelRepeats parameter in both languages - Added comprehensive tests for new functionality - All tests passing Fixes review feedback about RepeatCounter responsibilities
|
Thank you for your contribution. The changes have been released in @testplane/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration option parallelRepeats that gives users control over how repeated tests are executed:
New features
- Add parallelRepeats option (default: true)
Parallel mode (true): All test repeats are queued upfront for maximum throughput
Sequential mode (false): Each repeat is queued only after the previous one completes
Usage example