fix: tests location when calling list-tests cli command #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Sep 22, 2025
Comment on lines
113
to
126
| const enableSourceMaps = (): void => { | ||
| if (areSourceMapsEnabled) { | ||
| return; | ||
| } | ||
|
|
||
| areSourceMapsEnabled = true; | ||
|
|
||
| revertTransformHook(); | ||
|
|
||
| revertTransformHook = addHook( | ||
| (code, filename) => transformCode(code, { sourceFile: filename, sourceMaps: true, isSilent }), | ||
| { | ||
| exts: TRANSFORM_EXTENSIONS, | ||
| matcher: filename => !filename.includes("node_modules"), | ||
| ignoreNodeModules: false, | ||
| }, | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Usually we register transform hook without sourcemaps so we dont waste any time generating it
This function will re-register transform hook with sourcemaps
commit: |
DudaGod
approved these changes
Sep 23, 2025
src/utils/typescript.ts
Outdated
| matcher: filename => !filename.includes("node_modules"), | ||
| ignoreNodeModules: false, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
can we get rid of duplication here (only value of sourceMaps flag changes)?
| assert.notCalled(addHookStub); | ||
| }); | ||
|
|
||
| it("should re-register transform hook with source maps", () => { |
There was a problem hiding this comment.
But you didn't check that the flag sourceMap: true is specified on second call
There was a problem hiding this comment.
We cant.
We just pass callback (code, filename) => transformCode(...) to "addHook"
So "addHook" was just called with some function and thats all we can get.
"flag sourceMap: true" is internal detail of "registerTransformHook" function implementation
KuznetsovRoman
force-pushed
the
TESTPLANE-735.fix_test_location
branch
2 times, most recently
from
f657808 to
0e3c950
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-735.fix_test_location
branch
from
0e3c950 to
56a12cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.