fix(diff): improve sidebar deleted-file presentation#1451
Merged
arnestrickmann merged 2 commits intogeneralaction:mainfrom Mar 13, 2026
Merged
fix(diff): improve sidebar deleted-file presentation#1451arnestrickmann merged 2 commits intogeneralaction:mainfrom
arnestrickmann merged 2 commits intogeneralaction:mainfrom
Conversation
|
@jschwxrz is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThis PR improves the diff sidebar's file list by visually distinguishing deleted files: their filenames now render with Key changes and observations:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| src/renderer/components/FileChangesPanel.tsx | Adds strikethrough styling for deleted file names in the sidebar and conditionally suppresses diff pills for deleted files and zero-count non-deleted files. Minor issues: redundant CSS class in ternary, shouldShowDiffPill returns true for null which may contradict the stated "non-zero only" intent, and the directory segment of a deleted path is not struck through. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Render sidebar file entry] --> B{change.status === 'deleted'?}
B -- Yes --> C[Apply line-through to filename]
B -- No --> D[Normal filename styling]
C --> E[Skip diff pills entirely]
D --> F{shouldShowDiffPill\nadditions}
F -- true --> G[Render additions pill\n+N or +?]
F -- false\nvalue === 0 --> H[Hide additions pill]
D --> I{shouldShowDiffPill\ndeletions}
I -- true --> J[Render deletions pill\n-N or -?]
I -- false\nvalue === 0 --> K[Hide deletions pill]
subgraph shouldShowDiffPill logic
L[value] --> M{typeof value\n!== 'number'?}
M -- Yes\nnull or undefined --> N[return true\nshow pill with '?']
M -- No --> O{value !== 0?}
O -- Yes --> P[return true\nshow pill]
O -- No --> Q[return false\nhide pill]
end
Last reviewed commit: 0b614e8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary:
changes:
This improves scanability and avoids noisy/ambiguous counters in the sidebar.
fixes #1444