Repository navigation
ci: skip legacy test job when the discovered matrix is empty - #109
Merged
markstur merged 1 commit intoOct 27, 2026
Merged
Conversation
CI - Legacy Subpackages has been failing on main and on PRs that touch legacy-ci.yml or quality-generic.yml since the flat-package restructure: the discovery step scans mellea_contribs/**, which no longer exists, so the matrix is always empty — and a reusable-workflow (uses:) job with an empty matrix fails the run instead of skipping. Add the same empty-matrix guard the test job in ci.yml already has so the job skips cleanly. Whether the legacy workflows should instead be deleted outright is tracked separately. Fixes generative-computing#108 Assisted-by: Claude Code Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
markstur
requested review from
AngeloDanducci,
planetf1 and
rafvasq
and removed request for
a team
October 23, 2026 21:26
Contributor
Author
|
NOTE: See issue regarding skip vs remove. This is the more conservative first pass, but should we remove? |
AngeloDanducci
approved these changes
Oct 27, 2026
AngeloDanducci
left a comment
AngeloDanducci
left a comment
There was a problem hiding this comment.
I think it's fine to leave as is for now, can always remove later.
LGTM
Merged
via the queue into
generative-computing:main
with commit Oct 27, 2026
a0db1d8
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI - Legacy Subpackageshas been failing onmainand on any PR touchinglegacy-ci.ymlorquality-generic.ymlsince the flat-package restructure (~2026-07-07). The discovery step scansmellea_contribs/**, which no longer exists, so the matrix is always empty — and a reusable-workflow (uses:) job with an empty matrix fails the run instead of skipping it.Surfaced by PR #107 (which touches
quality-generic.yml, one of the workflow's path filters), but pre-existing and unrelated to it. Details in #108.Fix
Add the same empty-matrix guard the
testjob inci.ymlalready has:The job now skips cleanly when nothing is discovered. Whether
legacy-ci.yml+quality-generic.ymlshould instead be deleted outright (they can only ever exercise the oldmellea_contribs/layout) stays open in #108.Fixes #108
🤖 Generated with Claude Code