fix(#83): RelatedAgents' BIC may be in BICFI instead of BIC node #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PowerKiKi Would you mind to review the PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
============================================
+ Coverage 83.22% 83.28% +0.06%
- Complexity 680 682 +2
============================================
Files 81 81
Lines 1657 1663 +6
============================================
+ Hits 1379 1385 +6
Misses 278 278 ☔ View full report in Codecov by Sentry. |
|
Sorry it took so long, but it's been released: https://github.com/genkgo/camt/releases/tag/2.7.0 |
Alvyre
pushed a commit
to stadline/camt
that referenced
this pull request
Oct 9, 2024
genkgo#150) RelatedAgents' BIC is also available in CAMT 054 Because the RelatedAgents' BIC may be in BICFI instead of BIC node Fixes genkgo#83 --------- Co-authored-by: Thomas Lamy <[email protected]> Co-authored-by: Adrien Crivelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #83 for us, where at least in the camt.054.001.08 documents we receive the related agents' BIC are in BICFI nodes.
Test cases are also modified of course.