Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
shepardxia
reviewed
Apr 2, 2026
shepardxia
left a comment
shepardxia
left a comment
There was a problem hiding this comment.
lgtm! Comments are mostly stylistic nitpicking.
pyproject.toml
Outdated
| "genlm-backend>=0.1.8", | ||
| "genlm-bytes>=0.1.2", | ||
| "genlm-backend @ git+https://github.com/genlm/genlm-backend.git@samuki/refactor-token-bytes", | ||
| "genlm-bytes @ git+https://github.com/genlm/genlm-bytes.git@yahya/refactor", |
ClementeP
reviewed
Apr 2, 2026
genlm/control/util.py
Outdated
| # Fallback: if token is plain bytes (not Token), search by byte_string content. | ||
| # This supports old code that indexes by bytes; returns the first match. | ||
| if Token.is_plain_bytes(token): | ||
| for vocab_token in self.decode: |
Contributor
There was a problem hiding this comment.
The fallback seems to be very slow ( O(n) ) --- could we use a dictionary to look this up ?
vicky-xef
approved these changes
Apr 2, 2026
This was referenced Apr 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Switch from byte strings to token objects to handle duplicate byte strings. Fixes issue where multiple token IDs can decode to the same byte string. Builds on the new backend that returns token objects instead of bytes: genlm/genlm-backend#57