Conversation
benlebrun
requested changes
Nov 15, 2025
docs/cookbook/custom_domains.ipynb
Outdated
| "1. Define your dataset\n", | ||
| "2. Implement an evaluator\n", | ||
| "3. Implement a model adaptor\n", | ||
| "3. Implement custom potentials\n", |
Member
There was a problem hiding this comment.
I don't think we should assume that people will only be evaluating models with potentials using this framework.
benlebrun
approved these changes
Nov 18, 2025
Member
benlebrun
left a comment
benlebrun
left a comment
There was a problem hiding this comment.
One minor comment but otherwise LGTM
docs/cookbook/custom_domains.ipynb
Outdated
| " # Run SMC with 5 particles, a maximum of 25 tokens, and an ESS threshold of 0.5\n", | ||
| " sequences = await sampler.smc(\n", | ||
| " n_particles=5,\n", | ||
| " ess_threshold=0.5,\n", |
Member
There was a problem hiding this comment.
ess_threshold should be zero if we are directly sampling from LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend documentation to include potentials and prompt formatting.