Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #82

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Patch 1 #82

wants to merge 5 commits into from

Conversation

liuweisu
Copy link

@liuweisu liuweisu commented Jun 8, 2023

nf-core/nanoclust pull request

Many thanks for contributing to nf-core/nanoclust!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/nanoclust branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

liuweisu added 5 commits May 5, 2023 02:05
Sometimes there would be empty values from previous steps of the NanoCLUST pipeline, however, this would result in the following error: 

Command exit status:
  1

Command output:
  (empty)

Command error:
  Traceback (most recent call last):
    File ".command.sh", line 65, in <module>
      get_abundance(names,paths, "G")
    File ".command.sh", line 59, in get_abundance
      df_final_grp = merge_abundance(dfs, tax_level)
    File ".command.sh", line 49, in merge_abundance
      df_final["taxid"] = [get_taxname(row["taxid"], tax_level) for index, row in df_final.iterrows()]
    File ".command.sh", line 49, in <listcomp>
      df_final["taxid"] = [get_taxname(row["taxid"], tax_level) for index, row in df_final.iterrows()]
    File ".command.sh", line 28, in get_taxname
      return json.loads(complete_tax)[0][tax_level_tag]
  IndexError: list index out of range

So I changed the code (updated code on line 23 to 28), and this gave me no errors.
Sorry I forgot to move the "return name" line
HDBSCAN AND UMAP-LEARN update + addition of numba and llvmlite
Fixing of creating new matplotlib folders in your directory
Changed the Umap Set Size to 84000 in order to prevent error 137 (lack of computational power)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant