Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move akonadiserverrc and optional RDEPENDS to kde-apps/akonadi-config (new package) #1007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move akonadiserverrc and optional RDEPENDS to kde-apps/akonadi-config (new package) #1007

wants to merge 1 commit into from

Conversation

a17r
Copy link
Member

@a17r a17r commented Oct 12, 2024 •
edited
Loading

  • kde-apps/akonadi-config: new package, add 0
    Essentially split out of kde-apps/akonadi.
    
    This is now responsible for setting up default akonadiserverrc, and at
    the same time, switching default backend to QSQLITE (USE=sqlite) with
    some basic instructions.
    
    In terms of optional RDEPEND IUSE, we can treat this like a metapackage
    ensuring appropriate runtime dependencies.
    
    Bug: https://bugs.gentoo.org/936102
  • kde-apps/akonadi: Drop IUSE mysql,postgres,sqlite and akonadiserverrc
    Moved to kde-apps/akonadi-config. These flags were never ticking build
    system arguments to begin with.
  • kde-apps/akonadi-config: Switch default to QSQLITE (IUSE sqlite)

@a17r a17r requested review from thesamesam and ArsenArsen October 12, 2024 14:10
@a17r
Copy link
Member Author

a17r commented Oct 12, 2024

Do we need to be careful with some Portage peculiarities since a config protected file is changing ownership?

@a17r a17r requested a review from SoapGentoo October 12, 2024 14:48
thesamesam
thesamesam approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've decided no news item then?

kde-apps/akonadi-config/akonadi-config-0.ebuild Outdated Show resolved Hide resolved
kde-apps/akonadi-config/akonadi-config-0.ebuild Outdated
elog "${DRIVER} has been set as your default akonadi storage backend."
elog
optfeature_header "The following optional database backends exist:"
optfeature "QSQLITE backend support" "${CATEGORY}/${PN}[sqlite]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing is indeed correct, although odd! Although maybe would look better to just say the real names (SQLite, MySQL, PostgreSQL)

@a17r
Copy link
Member Author

a17r commented Oct 12, 2024

We've decided no news item then?

Not decided yet.

@a17r a17r force-pushed the akonadi branch 3 times, most recently from ad8d3d8 to 84183c3 Compare October 13, 2024 08:08
@a17r
Copy link
Member Author

a17r commented Oct 13, 2024

Introduction with 24.08.3?

SoapGentoo
SoapGentoo approved these changes Oct 13, 2024
View reviewed changes
kde-apps/akonadi-config/akonadi-config-0.ebuild
}

pkg_setup() {
# Set default storage backend in order: SQLite, MySQL, PostgreSQL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoapGentoo SoapGentoo SoapGentoo approved these changes

@thesamesam thesamesam thesamesam approved these changes

@ArsenArsen ArsenArsen ArsenArsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a17r @ArsenArsen @thesamesam @SoapGentoo