-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add several Mauikit applications #910
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please apply review globally
- Never use kde-apps/ category. Choose appropriate one.
- I'm wondering if there aren't some more
RDEPEND
-only dependencies missing in general like kirigami, qtquickcontrols(2) etc.
>=dev-qt/qtsql-${QTMIN}:5 | ||
>=dev-qt/qtcore-${QTMIN}:5 | ||
>=dev-qt/qtnetwork-${QTMIN}:5 | ||
>=dev-qt/qtdeclarative-${QTMIN}:5 | ||
|
||
>=dev-libs/mauikit-${KFMIN}:5 | ||
>=kde-frameworks/ki18n-${KFMIN}:5 | ||
>=kde-frameworks/kcoreaddons-${KFMIN}:5 | ||
>=kde-frameworks/kconfig-${KFMIN}:5[qml] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort alphanumerically
|
||
DEPEND=" | ||
>=dev-qt/qtsql-${QTMIN}:5 | ||
>=dev-qt/qtcore-${QTMIN}:5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev-qt/qtcore is depended on by ecm.eclass
already, you can drop it on all consumers.
IUSE="" | ||
|
||
DEPEND=" | ||
sys-devel/gettext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely no RDEPEND
. Likely BDEPEND
?
>=kde-frameworks/kcoreaddons-${KFMIN}:5 | ||
>=kde-frameworks/kconfig-${KFMIN}:5[qml] | ||
>=kde-frameworks/extra-cmake-modules-${KFMIN}:5 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no bogus newlines within strings please
dev-libs/mauiman/mauiman-9999.ebuild
Outdated
# unsure, but mauikit is GPL3 | ||
LICENSE="GPL-3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could check other distros
kde-apps/clip/clip-9999.ebuild
Outdated
DEPEND=" | ||
media-libs/taglib | ||
media-video/ffmpeg | ||
mpv? ( media-video/mpv[libmpv] ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional deps below unconditional deps
kde-apps/clip/clip-9999.ebuild
Outdated
|
||
DEPEND=" | ||
media-libs/taglib | ||
media-video/ffmpeg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure requires :=
slot operator
kde-apps/clip/metadata.xml
Outdated
<pkgmetadata> | ||
<use> | ||
<flag name="mpv">Embed media-video/mpv for playback using libmpv</flag> | ||
</use> | ||
</pkgmetadata> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tab indentation please
Thanks, will fix all of it |
Please squash commits - when we merge this PR it shall be one clean commit per new package. We don't add review noise to ebuild repositories. I can see there are already fixing commits over multiple packages, it is easy in git to untangle again, visit #gentoo-dev-help if you need pointers. Though I'm not there right now because I'm on holidays. |
Sure, will do once I'm done! |
b9c69eb
to
b2b3134
Compare
Also makes mauikit depend on mauiman Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Needed for the Pix image viewer Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
@a17r: all done! Some of the licenses upstream are contradicting, but I got this response in Nitrux TG:
So I set everything to LGPL-3. |
This PR adds many Mauikit applications with dependencies. There are some left including the Station terminal. Station in particular uses qmltermwidget which needs some patches to run it seems.
Signed-off-by: Alfred Persson Forsberg [email protected]