Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several Mauikit applications #910

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

alfredfo
Copy link
Contributor

@alfredfo alfredfo commented Aug 7, 2022

This PR adds many Mauikit applications with dependencies. There are some left including the Station terminal. Station in particular uses qmltermwidget which needs some patches to run it seems.

Signed-off-by: Alfred Persson Forsberg [email protected]

Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please apply review globally
  • Never use kde-apps/ category. Choose appropriate one.
  • I'm wondering if there aren't some more RDEPEND-only dependencies missing in general like kirigami, qtquickcontrols(2) etc.

dev-libs/mauikit-accounts/mauikit-accounts-9999.ebuild Outdated Show resolved Hide resolved
dev-libs/mauikit-accounts/mauikit-accounts-9999.ebuild Outdated Show resolved Hide resolved
Comment on lines 20 to 25
>=dev-qt/qtsql-${QTMIN}:5
>=dev-qt/qtcore-${QTMIN}:5
>=dev-qt/qtnetwork-${QTMIN}:5
>=dev-qt/qtdeclarative-${QTMIN}:5

>=dev-libs/mauikit-${KFMIN}:5
>=kde-frameworks/ki18n-${KFMIN}:5
>=kde-frameworks/kcoreaddons-${KFMIN}:5
>=kde-frameworks/kconfig-${KFMIN}:5[qml]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort alphanumerically


DEPEND="
>=dev-qt/qtsql-${QTMIN}:5
>=dev-qt/qtcore-${QTMIN}:5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-qt/qtcore is depended on by ecm.eclass already, you can drop it on all consumers.

IUSE=""

DEPEND="
sys-devel/gettext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely no RDEPEND. Likely BDEPEND?

>=kde-frameworks/kcoreaddons-${KFMIN}:5
>=kde-frameworks/kconfig-${KFMIN}:5[qml]
>=kde-frameworks/extra-cmake-modules-${KFMIN}:5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no bogus newlines within strings please

Comment on lines 14 to 15
# unsure, but mauikit is GPL3
LICENSE="GPL-3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could check other distros

DEPEND="
media-libs/taglib
media-video/ffmpeg
mpv? ( media-video/mpv[libmpv] )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional deps below unconditional deps


DEPEND="
media-libs/taglib
media-video/ffmpeg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure requires := slot operator

Comment on lines 3 to 7
<pkgmetadata>
<use>
<flag name="mpv">Embed media-video/mpv for playback using libmpv</flag>
</use>
</pkgmetadata>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab indentation please

@alfredfo
Copy link
Contributor Author

alfredfo commented Aug 9, 2022

Thanks, will fix all of it

@a17r
Copy link
Member

a17r commented Aug 10, 2022

Please squash commits - when we merge this PR it shall be one clean commit per new package. We don't add review noise to ebuild repositories.

I can see there are already fixing commits over multiple packages, it is easy in git to untangle again, visit #gentoo-dev-help if you need pointers. Though I'm not there right now because I'm on holidays.

@alfredfo
Copy link
Contributor Author

alfredfo commented Aug 10, 2022

Please squash commits - when we merge this PR it shall be one clean commit per new package. We don't add review noise to ebuild repositories.

Sure, will do once I'm done!

@alfredfo alfredfo force-pushed the master branch 2 times, most recently from b9c69eb to b2b3134 Compare August 15, 2022 21:20
Also makes mauikit depend on mauiman

Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Needed for the Pix image viewer

Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
Signed-off-by: Alfred Persson Forsberg <[email protected]>
@alfredfo
Copy link
Contributor Author

@a17r: all done!

Some of the licenses upstream are contradicting, but I got this response in Nitrux TG:

The license for MauiKit, MauiKit Frameworks, and our apps is LGPL 3.

If the license files of these repositories show otherwise, they need to be updated

So I set everything to LGPL-3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants