Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: lib.sh: Support slot scope in get_main_tree_keyword() #975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a17r
Copy link
Member

@a17r a17r commented Jan 7, 2024

In general, use more portageq instead of sed, grep, ls, sort and tail.

@a17r a17r requested review from ionenwks and thesamesam January 7, 2024 11:39
Copy link
Contributor

@ionenwks ionenwks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with these scripts but I don't see anything that stands out as bad in the changes from a quick look.

@a17r
Copy link
Member Author

a17r commented Feb 22, 2024

Needs more work for the case of no ebuild in main tree available.

In general, use more portageq instead of sed, grep, ls, sort and tail.

Signed-off-by: Andreas Sturmlechner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants