ebuild: do not drop FEATURES=test when USE=-test #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By convention the "test" USE flag is used to control dependencies required for execution of the src_test function. The "test" USE flag has no special meaning in PMS. The Gentoo Policy Guide [1] advises that ebuilds must make use of RESTRICT to disable tests based on USE flags. Current versions of Portage will not run tests when RESTRICT=test is set, regardless of the FEATURES setting. This code in Portage predates the Gentoo policy. It is unneeded since the policy was created and ebuilds have been updated with the necessary RESTRICT values. [1] https://projects.gentoo.org/qa/policy-guide/other-metadata.html#pg0703 Signed-off-by: Mike Gilbert <[email protected]>
|
The interaction between EBUILD_FORCE_TEST and use.mask has implication for the |
|
Hmm. I would would say that EBUILD_FORCE_TEST should only cause the test phase to be executed, possibly even overriding RESTRICT. I don't see any reason to modify USE based on EBUILD_FORCE_TEST, especially since it is only meant for developers. |
zmedico
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By convention the "test" USE flag is used to control dependencies required for execution of the src_test function.
The "test" USE flag has no special meaning in PMS.
The Gentoo Policy Guide [1] advises that ebuilds must make use of RESTRICT to disable tests based on USE flags.
Current versions of Portage will not run tests when RESTRICT=test is set, regardless of the FEATURES setting.
This code in Portage predates the Gentoo policy. It is unneeded since the policy was created and ebuilds have been updated with the necessary RESTRICT values.
[1] https://projects.gentoo.org/qa/policy-guide/other-metadata.html#pg0703