Merge pull request #60 from limrv/accept-blank-init

Accept empty string as initialization value
gentooboontoo · Apr 13, 2016 · b5fdafb · b5fdafb
2 parents dc3b5d7 + dad85e1
commit b5fdafb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/spec/quantitiesSpec.js b/spec/quantitiesSpec.js
@@ -219,13 +219,9 @@ describe("js-quantities", function() {
       expect(function() { Qty("mmm"); }).toThrow("Unit not recognized");
     });
 
-    it("should throw error when passing an empty string", function() {
-      expect(
-        function() { Qty(""); }
-      ).toThrow("Unit not recognized");
-      expect(
-        function() { Qty("   "); }
-      ).toThrow("Unit not recognized");
+    it("should accept empty string as unitless 1", function() {
+      expect(Qty("").same(Qty("1"))).toBe(true);
+      expect(Qty("   ").same(Qty("1"))).toBe(true);
     });
 
     it("should throw error when passing a null value", function() {

diff --git a/src/quantities.js b/src/quantities.js
@@ -671,9 +671,6 @@ SOFTWARE.
       val = val.toString();
     }
     val = val.trim();
-    if (val.length === 0) {
-      throw new QtyError("Unit not recognized");
-    }
 
     var result = QTY_STRING_REGEX.exec(val);
     if (!result) {