Add getUnits and getAliases addresses #48 #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one solution to the issue. In #14 @rage-shadowman had mentioned "Another alternative, if you don't want ambiguous arrays, would be to return only the unit names (ie: for "" return "liter" -- the name sans the "<>" chars) and a getAliases method to get all the aliases for a named unit (["l", "L", "liter", "liters", "litre", "litres"]) or maybe event all the alternative aliases for a given alias (such that getAlternatives("liter") returns an identical array to getAlternatives("L"))."
I agree the grouped arrays are ambiguous, so I'm using that approach:
So only one name for each unit is returned.
Also:
So getUnits is sorted to make it perfect for feeding choices to the user. (Select box, predictive input)
@gentooboontoo also mentioned the getAliases method and again i agree, these should be separate functions. If this goes over well I can make a separate commit for the getPrefixes but I think there are quite a few versions of that that looked great already. They just are bundled up with these other changes.
Thanks for js-quantities! It's working out for us.