Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #409

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Build fixes #409

wants to merge 4 commits into from

Conversation

gzsombor
Copy link

#365 : Fix the build, so it should work out of the box, without hand tuning, copying various files around. But instead of fixing the documentation, it is better to fix the actual code ( http://www.goldyliang.net/blog/how-to-build-fbreaderj-android/ )

@bibliotecaortodoxa-ro
Copy link

After file move to the same package, just delete the import org.fbreader.util.NaturalOrderComparator; . There is no need to add that line
import group.pals.android.lib.ui.filechooser.utils.NaturalOrderComparator;

@dbdean
Copy link

dbdean commented Mar 24, 2017

@geometer, is there anything preventing this from being pulled into the main repo? It would have certainly saved me a lot of time. Thanks!

@gzsombor
Copy link
Author

It seems that this project is effectively dead. My other pull request, about adding a new menu item "Recently downloaded books" is still open since May of 2016. Do you have desire to work on FBReaderJ ?

@dbdean
Copy link

dbdean commented Mar 27, 2017

@gzsombor, I was hoping to change the way graphics were rendered in night mode, so that they didn't have a bright white background, but it does appear that at least the open source code here is pretty dead. However, fbreader seems to be continuing as an app, so I suspect @geometer might be continuing development as closed source, which seems to leave little point in contributing code, as it won't turn up in the play-store app anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants