[Datahub] Fix dates #1075
Merged
[Datahub] Fix dates #1075
+36
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
|
📷 Screenshots are here! |
AlitaBernachot
force-pushed
the
GSGCT-139-fix-dates-resources
branch
2 times, most recently
from
6910b5a to
129b94e
Compare
jahow
approved these changes
Jan 27, 2025
| ) | ||
| return { | ||
| ...output, | ||
| recordPublished: datePublished, |
There was a problem hiding this comment.
Am I guessing right that this is kept for backwards compatibility? I think there can theoretically be a publicationDate field coming from the index so I would rely on this one instead of publicationDateForResource, but maybe you had a good reason to do so
There was a problem hiding this comment.
Here is an update: https://github.com/geonetwork/geonetwork-ui/pull/1075/files#diff-3e4fae1b2969801149a83f9b728e055e203e1b65a4b0e51c83951edfc8104573R145
Is that what you meant?
AlitaBernachot
force-pushed
the
GSGCT-139-fix-dates-resources
branch
2 times, most recently
from
0a4c115 to
929ccfc
Compare
AlitaBernachot
force-pushed
the
GSGCT-139-fix-dates-resources
branch
from
d682aab to
70c055f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the content of the "About the data" section regarding the dates: instead of displaying the metadata dates, we now display the resource related dates (
recordUpdated,resourceCreated, andresourcePublishedinstead ofrecordCreatedandrecordPublished).Architectural changes
Breaking change:
publicationDateForResourcenow becomesresourcePublishedafter conversion (instead ofrecordPublished)publicationDatebecomesrecordPublishedafter conversion (new)Screenshots
No change in the UI.
Quality Assurance Checklist
breaking changelabelbackport <release branch>label