-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datahub] Add reuse metadata support #1086
Conversation
Affected libs:
|
1a68f1d
to
b3f9cda
Compare
16853b8
to
d880b52
Compare
📷 Screenshots are here! |
713f62b
to
ede3740
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks really good, great work! I added a couple of comments to make a few things a little bit clearer, but apart from that it's all good. Please merge once you've addressed the comments as you see fit :)
return { | ||
...output, | ||
kind, | ||
reuseType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reuseType, | |
...(reuseType || { reuseType }), |
We should not write this key if the reuseType is undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! I updated the gn4 field mapper and added a ut for this specific use case.
@@ -339,6 +340,7 @@ export class Iso19139Converter extends BaseConverter<string> { | |||
|
|||
fieldChanged('uniqueIdentifier') && | |||
this.writers['uniqueIdentifier'](record, rootEl) | |||
fieldChanged('reuseType') && this.writers['kind'](record, rootEl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks potentially confusing; maybe we can still have a "reuseType" writer and simply call the "kind" writer inside? At least we would have a homogeneous logic everywhere, even if it's an unnecessary step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I have added a new writer for reuseType
that is calling the kind
writer.
dc2734b
to
ea83ce2
Compare
528199c
to
7b3d945
Compare
Description
This PR adds the support of the new type of metadata:
Reuse metadata
, for:gn4
(read),iso19139
(read/write)iso19115
-3 (read-write).Architectural changes
The new
ReuseRecord
Metadata Model has been addedalong with with
ReuseType
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label