Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Natural Earth Cities and Natural Earth Lakes #26

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

tsutterley
Copy link
Contributor

naturalearth.countries would parallel the prior geopandas naturalearth_lowres dataset

thanks to @JessicaS11 for pointing out the missing geodatasets

`naturalearth.countries` would parallel the prior `geopandas` `naturalearth_lowres` dataset
@martinfleis
Copy link
Member

Hey, thanks for the PR.

However, I will ask you to remove naturalearth.countries and hydrosheds (for different reasons).

Geodatasets has a strict policy of avoiding data reflecting contested political boundaries, so a dataset representing countries of the world will never be admitted.

Hydrosheds are out of scope due to the size of the data. We're aiming to provide links to data that are useful for learning and illustrative purposes. This dataset has 820MB, which significantly exceeds what I'd consider useful for such purpose.

I am potentially fine with keeping cities and lakes though, there's no harm in having those.

@tsutterley
Copy link
Contributor Author

Makes perfect sense. Trimmed the json of those entries.

@martinfleis martinfleis changed the title add naturalearth and hydrosheds entries Add Natural Earth Cities and Natural Earth Lakes Sep 4, 2024
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinfleis martinfleis merged commit 8c249b7 into geopandas:main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants