Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace strlcat symbol in vendored netcdf source code with a prefixed version #138

Merged

Conversation

weiznich
Copy link
Contributor

@weiznich weiznich commented Apr 9, 2024

This PR adds another patch to the vendored version of the netcdf source code to replace the strlcat symbol with vendored version to prevent duplicated symbols at the linking stage if any other dependency also includes a vendored version of strlcat. This is essentially Unidata/netcdf-c#2906, but adjusted to the vendored version (the function definition is in a different file). I found this issue while working on the CI setup for georust/gdal#517 (that PR is essentially blocked on this one now…)

@weiznich weiznich force-pushed the fix/duplicated_strlcat_symbol branch from 2923099 to 3e783cf Compare April 9, 2024 06:23
@magnusuMET magnusuMET merged commit 6dadea7 into georust:master Apr 9, 2024
13 checks passed
@magnusuMET
Copy link
Member

Thanks! Just released netcdf-src-v0.3.3 which includes this fix

@weiznich
Copy link
Contributor Author

weiznich commented Apr 9, 2024

Thanks for the fast turnaround ❤️

That's really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants