Skip to content

Fix transcription error in implementation of OMT bulk loading #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamreichold merged 1 commit into from
Feb 25, 2026
Merged

Fix transcription error in implementation of OMT bulk loading #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rstar/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

## Fixed
- Fix excessive memory retention in `bulk_load` from `Vec::split_off` over-capacity
- Fix transcription error in implementation of OMT bulk loading leading to nodes which are too large.

## Changed
- Made `RStar` methods take `Point` and `Envelope` as owned values where it makes sense ([PR](https://github.com/georust/rstar/pull/189))
Expand Down
2 changes: 1 addition & 1 deletion rstar/src/algorithm/bulk_load/cluster_group_iterator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ where

let max_dimension = <T::Envelope as Envelope>::Point::DIMENSIONS as f32;
// Try to split all clusters among all dimensions as evenly as possible by taking the nth root.
number_of_clusters.powf(1. / max_dimension).ceil() as usize
number_of_clusters.powf(1. / max_dimension).floor() as usize
}

fn div_up(dividend: usize, divisor: usize) -> usize {
Expand Down