Avoid unclear diameter terminology in AABB::from_center.#223
Avoid unclear diameter terminology in AABB::from_center.#223adamreichold wants to merge 1 commit intomasterfrom
Conversation
|
Trying to address #222 (comment) |
michaelkirk
left a comment
There was a problem hiding this comment.
I was expecting "width". I guess it's a little funny because width == height.
To my (US_en) eye, "distance" is more or less synonymous with diameter.
In particular: the distance from the center to the edge is not the same as the distance from the center to the corner.
Is there another popular rectangle API that uses this "distance" term? Everything I find is either min/max points or origin,width,height.
I can't find another implementation of our funny width==height constructor.
|
My idea behind the choice of "distance" was that this is the smallest AABB which includes all points within the given distance of the center? (This should even be true no matter which metric on R^n is chosen, shouldn't it?) However, I am personally not particularly invested in any terminology and will happily change this if you have a clear favourite? (Or anybody else for that matter.)
At least to me, "distance" would be synonymous to radius instead of diameter. |
rstar/CHANGELOG.mdif knowledge of this change could be valuable to users.