Open
Conversation
Member
|
We discussed this in #169 and decided against it. Could you check that discussion if something has significantly changed since then? Thanks. |
Author
|
Basically allowing this would save us having to write a separate tree data structure and special-case it in several places for 1D. In our use case we're definitely not going to run into the situation that this would be slow in 1D. Perhaps a note in the docs saying "1D is supported but is potentially a stupid idea"? If not then I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rstar/CHANGELOG.mdif knowledge of this change could be valuable to users.Allow construction of 1D rtrees. I can't see at a glance why this shouldn't be okay. Added some basic tests.