Bugfix isolated nodes #296
Open
+427
−718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pull request problems gephi#200
mbastian
requested changes
Mar 29, 2023
| public static boolean isIsolatedNode(Graph graph, Node node) { | ||
| for (Node s : graph.getNodes()) { | ||
| if (graph.isAdjacent(node, s)) { | ||
| return false; |
There was a problem hiding this comment.
This will provoke NOT releasing the underlying read lock and therefore hang Gephi.
The following will make sure to release the read lock as well:
NodeIterable iterable = graph.getNodes();
for (Node s : iterable) {
if (graph.isAdjacent(node, s)) {
iterable.doBreak();
return false;
}
}
There was a problem hiding this comment.
Hi! I made the changes as you requested, can you make a check, please? Any other suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New plugin or plugin update?
What is the purpose of this plugin?
Generate Bridging Centrality of a Graph
How to test your plugin in Gephi?
Checklist before submission
masterbranch to get the latest updates?pom.xmlfile