-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use schema.link.fish instead. #4
base: master
Are you sure you want to change the base?
Conversation
@richardhundt @geraintluff I did some tests to tv4 validate the schemas and some validation was wrong, var data = {
"@context": "http://schema.org",
"@type": "Event",
"name": "Example Band goes to San Francisco",
"startDate" : "2013-09-14T21:30",
"url" : "http://example.com/tourdates.html",
"location" : {
"@type" : "Place",
"sameAs" : "http://www.hi-dive.com",
"name" : "The Hi-Dive",
"address" : "7 S. Broadway, Denver, CO 80209"
}
} You can reproduce it with node.js and this snippet : https://gist.github.com/sebilasse/6691e0ee170ac2c45b5e5319c645634d From the error stack: Most errors come from Thing.json. The "Expected Type" from schema.org is "URL" and in link.fish it has The above data is an official snippet from google and it seems in
...
SHOULD also allow subSchema itself ! In general I think the From schema.org:
Any thoughts? |
cc. @geraintluff @richardhundt : Are you sure you regenerated the I get in a blank but in https://github.com/silicon-ai/schema-org-gen and not being a |
Fixes issues described in geraintluff#4 - please merge geraintluff#4 first
Hey, sorry for the late response, just woke up to this thread now. Honestly, I haven't spent much time trying to get the generated schemas right. I was playing with it, and got as far as generating some schema fragments, but haven't tried any validation. In the end, JSON-LD + schema.org doesn't specify whether something is an array or not. It's flexible, so it's up to the application developer to figure it out. Makes this whole thing a bit tricky from a validation point of view. |
But this means it could be an array - currently only an array is allowed ... Probably ideal would be another option and just btw: also from germany, building a decentralized OpenSource/PayAsMuchYouWant node CMS. Having a router based on JSON-Schema nearly ready! |
The semantics of
instances
on http://schema.json.org doesn't imply anenum
in the target JSON schema, so I've removed it and the generated schemas look reasonably sane now.