Skip to content

Conversation

@gerlero
Copy link
Owner

@gerlero gerlero commented Apr 16, 2025

As discussed with @HenningScheufler.

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 85.28%. Comparing base (5076034) to head (a3fda5b).
Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
foamlib/__main__.py 0.00% 37 Missing ⚠️
foamlib/_util.py 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   88.20%   85.28%   -2.92%     
==========================================
  Files          15       17       +2     
  Lines        1492     1543      +51     
==========================================
  Hits         1316     1316              
- Misses        176      227      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gerlero
Copy link
Owner Author

gerlero commented Apr 16, 2025

@HenningScheufler I'm not sure if case directories should be passed as arguments or options (i.e. with --case). Having them as arguments looks cleaner (e.g. foamlib run /path/to/case), while having them as options allows for adding other arguments to run (e.g. foamlib run blockMesh --case /path/to/case). Let me know if you have any opinions on this.

Whatever the choice, plain foamlib run without any arguments/options should run the case in the current working directory.

@HenningScheufler
Copy link
Collaborator

We may want support additional options to run cases. So i think the --cases is a good option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants