Request caching + add ratelimit-over-408 + endpoint rewrite support #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanoeich
requested changes
May 6, 2024
There was a problem hiding this comment.
Thank you so much for the interest and contribution! I apologize for the delay reviewing this. There are some points of improvement but its all minor stuff, I like the changes and I think there is value in adding them to nirn :) Let me know if there are any questions about anything I've written here and let me know if these comments make sense to you aswell
Apply suffix change Co-authored-by: Germano Eichenberg <[email protected]>
Co-authored-by: Germano Eichenberg <[email protected]>
This also includes endpoint rewrites which is useful for the use case of custom gateway endpoints
cheesycod
changed the title
Co-authored-by: Germano Eichenberg <[email protected]>
Not used by upstream
|
@germanoeich Tried resolving the changes |
germanoeich
reviewed
Jun 28, 2024
Co-authored-by: Germano Eichenberg <[email protected]>
Co-authored-by: Germano Eichenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for (primitive) request caching for certain routes as well as the ability to 429 instead of 408 on a context deadline exceeded error. It also adds endpoint rewrite support which is useful in the instance where you may want to rewrite discord requests to other paths (for example, where the simple wsProxy string is not enough or if you have a seperate service for capturing state, an endpoint rewrite can be used to ensure all bots use it)