Update dependencies and changes for pandas 2.0 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to accommodate changes in pandas 2.0. Mainly responding to pandas default tz changing from `pytz.UTC` to `datetime.timezone.utc`. These revisions retain all timezones as pytz in `exchange_calendars`. Also: * makes changes in light of new pandas Warnings. * resolves #294 which moved from `FutureWarning` to Error when `CustomBusinessDay.apply` was deprecated in pandas 2.0.
Includes updating pandas to 2.0.
maread99
added
bug
|
There are no changes that would warrant the benchmark regression, which makes me suspect it's down to something inherent in pandas 2.0(?). Edit: benchmark passed on re-running the job (I'm assuming that's not due to the failed run having reset the benchmark?). |
|
Apologies - I've been on vacation. Thank you for grabbing this - it all looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dependencies and makes changes to accommodate pandas 2.0.
Changes mainly relate to pandas default timezone changing from
pytz.UTCtodatetime.timezone.utc. These revisionsretain all timezones in
exchange_calendarsaspytz.Also:
FutureWarningto Error whenCustomBusinessDay.applywas deprecated in pandas 2.0 (i.e. bug fix as XKRX not loading with pandas 2.0).@gerrymanoim - my intention's to merge this tomorrow and cut a new release as anyone currently installing
exchange_calendarswith pandas 2.0 will be experiencing behavior changes with regards to timezones and at least XKRX will be raising an error. Aside from tests for XKRX, 5 tests were failing and the test suite was raising a plethora of Warnings. With this PR there's just one Warning remaining which I'll raise an issue for (#300).