-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from pytz
to zoneinfo
#329
Conversation
Migrates code base and tests from `pytz` to `zoneinfo`.
f2a7bc0
to
dbe6bd0
Compare
Tests are passing in 3.9. A single test, The failure's odd. Something is resulting in the tz of the expected index to be set to a |
The issue was with |
Drops `pytz`, adds `tzdata`, to `pyproject.toml`. Pins latest deps on requirements files.
Always converts tz of columns of return from `pandas.read_csv` to `timezone.ZoneInfo("UTC")` (some combinations of pandas and python will return as `pytz.UTC`).
@gerrymanoim this is good to go. If you're happy with it I'll merge it (and the other PR that's come in) and cut 4.4. Closes #322. Cheers. |
LGTM. Did you do this manually? I've had good success using https://github.com/isidentical/refactor to do these types of large scale changes fyi. |
package-wide Find and Replace for most of it and then just manually tidied up where usage was a little different. A lot less painful than I was expecting. Spent three times as long unearthing the inconsistent behaviour from I'll merge and release tomorrow. Thanks for the head up with the refactor package, I'll check it out. |
Anticipate releasing under 4.4 early next week (w/c 23/09/11)... |
Migrates code base and tests from
pytz
tozoneinfo
.Also updates dependencies.