Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XKRX: Add extra holiday on 2023-10-02 #336

Merged

Conversation

philiptromans
Copy link

XKRX: Added an extra temporary holiday for 2023-10-02. Exchange press release here.

Workflow to modify an existing Exchange Calendar

  • Modify calendar class as required.
  • Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
  • Check if any of the fixtures in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
  • Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

@philiptromans
Copy link
Author

Looks like CI is a bit broken.

@philiptromans
Copy link
Author

I've added 83e9b05 which fixes CI. It should probably be in a separate PR though, so feel free to cherry pick if you want.

@gerrymanoim gerrymanoim merged commit a900da8 into gerrymanoim:master Sep 25, 2023
8 checks passed
@maread99 maread99 mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants