BUG: Fix end-date-only TZ logic in holiday.py #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herebebeasties
changed the title
herebebeasties
changed the title
|
Thanks again @herebebeasties. I believe the only calendar that uses this module is XKRX. There's been talk for a while (#128) of moving the calendar to hard-coded holidays and a standard implementation. I suspect that would allow the removal of the pandas_extensions directory and everything under it together with (possibly) the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think anything is actually using this, so hasn't tripped over it yet, but there is what looks like a "copy/pasta" bug in
holidays.pythat this fixes around handling of the range when the TZ is only specified on the end date. There is a missing assertion for matching start and end date timezones, too (there is currently what ruff calls a "pointless equality check" whose result is not checked).