Bump min support Python to 3.10 #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maread99
added
dependencies
Follows numpy 2.1 requiring >= 3.10,
Revisions to typing to benefit from bumping minimum supported Python version to 3.10. Removes now superfluous `from __future__ import annotations` lines and corrects typing syntax errors.
gerrymanoim
approved these changes
Sep 23, 2024
|
Thanks! LGTM - merge whenever you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gerrymanoim
The latest
numpyminor release (2.10) now requires Python >= 3.10. This PR bumps the minimum Python version forexchange_calendarsto 3.10 and amends the requirements file to the latestnumpyversion.Bumping the min allows us to lose most of the
from __future__ import annotationslines. This has the benefit that the interpreter now actually looks at the typing syntax (raising errors if the syntax is not correct).There's also the release of Python 3.13 around the corner - seems like a reasonable time to bump the min.
Cheers
Marcus