-
Notifications
You must be signed in to change notification settings - Fork 3
batch writes #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ianmacartney
wants to merge
16
commits into
main
Choose a base branch
from
ian/batch-writes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
batch writes #167
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b1c3f70
batch writes
ianmacartney 1036f84
fixes
ianmacartney 02a0df6
update example and change buffering to startBuffering / finishBuffering
ianmacartney 5cf5201
readme
ianmacartney af5bfbf
fix tests
ianmacartney 9e41724
update manual testing
ianmacartney 0d25f49
refactor more operations to share code
ianmacartney 83b1c9e
lint
ianmacartney 3efa4bc
0.2.2-alpha.0
ianmacartney 75f7c1e
await current flush promise
ianmacartney 395fbb8
await current flush promise and unify args
ianmacartney fa4a569
update batchedWrite example
ianmacartney 1a0bfd2
re-use args from op
ianmacartney 3b48c65
convexToJson the namespace key
ianmacartney 456bc21
update logging
ianmacartney 462c727
rename
ianmacartney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Batching-with-triggers snippet is missing key imports/context (
components,DataModel,v).In the added block, the snippet references
components.aggregate,DataModel, and usesvlater, but doesn’t show those imports (or where they come from). Consider adding the missing imports or a short comment that it’s an excerpt.