skip push on predev instead of always deploying twice #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmacartney
force-pushed
the
ian/predev-skip-push
branch
from
92aea43 to
3e600ef
Compare
ianmacartney
commented
Nov 30, 2025
| "dev:backend": "convex dev --typecheck-components", | ||
| "dev:frontend": "cd example && vite --clearScreen false", | ||
| "dev:build": "chokidar 'tsconfig*.json' 'src/**/*.ts' -i '**/*.test.ts' -c 'npx convex codegen --component-dir ./src/component && npm run build' --initial", | ||
| "predev": "path-exists .env.local || (npm run build && convex dev --until-success)", |
Collaborator
Author
There was a problem hiding this comment.
we might want to keep this to ensure the build happens once. unfortunately there can still be races where a deploy starts before dist/ files exist, so the file watcher misses their addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by doing
--skip-push, the user will select a deployment before running multiple things at once (gets past the interactive part), but we won't duplicate the push every time they start it up.I'm on the fence about whether opening the dashboard automatically is annoying - but they can change that pretty easily.
This makes the component template easier & takes out the
path-existsrequirementBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.