Asset task options implementation #556

davidlatwe · 2020-07-24T12:56:14Z

Intooduce Asset Task Option

This feature aims to allow each asset to have different config in different task at different period of production time, which could be useful in publish process or other part of pipeline.

Setup

Register task options by adding "options" into each "config.tasks" field in Avalon database's project document.
The peroject document would be like this:

{
    "type": "project",
    "config": {
        "tasks": [
            {
                "name": "rigging",
                "options": {
                    "autoModelUpdate": {
                        "label": "Auto update model",
                        "default": false,
                        "help": "Auto update model to latest version after model publish."
                    }
                }
            },
            {
                "name": "otherTaskThatHasNoOption"
            }
        ]
    }
}

And in .config.toml file:

[[tasks]]
name = "rigging"

[tasks.options.autoModelUpdate]
label = "Auto update model"
default = false
help = "Auto update model to latest version after model publish."

[[tasks]]
name = "otherTaskThatHasNoOption"

And the asset document will be added one extra field data.taskOptions when it's been applied:

{
    "type": "asset",
    "name": "Foo",
    "data": {
        "label": "Foo",
        "taskOptions": {
            "rigging": {
                "autoModelUpdate": {
                    "value": false
                }
            }
        },
        "tasks": [
            "rigging",
            "otherTaskThatHasNoOption"
        ]
    }
}

Usage

To apply/change task options to each asset, we implement a new widget into Avalon's project manager tool.

With this, you can:

View and update task option on each asset.
Able to update multiple tasks' options on multiple assets in one action when enabled "Batch Edit".

Notes

This widget is hidden by default, you need to drag it out from the right side of the window.
Option setup change will be written to database only when you pressed the "Save" button.
Current edit will lost if you changed the selection of asset or task.
Task widget's view has been enabled multi-selection for editing multiple task option on each asset. (This only applys to Project Manager, does not affect other tools)

tokejepsen · 2020-07-24T13:04:23Z

Not sure I entirely get the end goal of this?

Is it like a per task metadata, so the config can disable/enable plugins?

davidlatwe · 2020-07-24T13:08:19Z

Is it like a per task metadata, so the config can disable/enable plugins?

Yes, per task metadata that can be applied to each asset, and for example, like in publish plugins, can change the behavior based on those metadata in each asset.

davidlatwe · 2020-07-24T13:11:26Z

Our use case is, a rigger can set for one or more assets' rigs that is currently working on, which can be safely auto updated when model is being published.

tokejepsen · 2020-07-24T13:23:59Z

Side question about "auto update". How are you tracking this and when does it get triggered?

BigRoy · 2020-07-24T13:24:54Z

I like the fact of having specific rules/settings for an Asset but I do have some doubts about how this works. To get a clear picture I have a question first:

Could this also just be an "Asset" specific setting? As in, does it really need to be on the Task?

I imagine this could also just be on the asset's data

rigFaceJointLimit: 10
rigBodyJointLimit: 20
rigAutoUpdate: True

Seems like that was how it was originally intended (to be specific data to that asset).
In that sense it's more of User Interface front-end for asset data, which I think is a great step forward. E.g. also allowing to set an FPS override or resolution setting for a Shot in the Project Manager.

I guess the specification could allow for assetOptions that apply only to specific tasks (allowedTasks: ["rigging"])?

davidlatwe · 2020-07-24T13:52:03Z

Side question about "auto update". How are you tracking this and when does it get triggered?

@tokejepsen
We have a simple dependency tracking mechanism, but only in Maya. When publishing, the instance that is being published will lookup the history and see if any node that is part of loaded subset. If so, the version document's _id of that loaded subset will be written into the instance's version document for future lookup.

Could this also just be an "Asset" specific setting? As in, does it really need to be on the Task?

@BigRoy
(Hmm, maybe I shouldn't use the phrase "to each asset", since it does sounds like applying same settings to every asset ?)

Yes, it's asset specific settings when you apply options from those has been registered in project's tasks.

Before those option being applied to any assets, we need a way to define and present those options, and binding them with tasks seems a good fit.

E.g. also allowing to set an FPS override or resolution setting for a Shot in the Project Manager.
I guess the specification could allow for assetOptions that apply only to specific tasks (allowedTasks: ["rigging"])?

Ah, need to think about this, organizing those option into project document's "config.assetOptions" with "allowedTasks" entry seems to be more flexible !

davidlatwe · 2020-07-24T14:15:41Z

If we move the option's defenition it into a higher scope like "assetOptions", then the project document would be like:

{
    "type": "project",
    "config": {
        "assetOptions": [
            {
                "name": "rigAutoModelUpdate",
                "label": "Auto update model",
                "default": false,
                "help": "Auto update model to latest version after model publish.",
                "onTasks": [
                    "rigging"
                ]
            },
            {
                "name": "shotFps",
                "label": "Frame rate",
                "default": 24,
                "help": "Override frame rate for shot.",
                "onTasks": [
                    "layout",
                    "animating",
                    "lighting"
                ]
            }
        ]
    }
}

.config.toml:

[[assetOptions]]
name = "rigAutoModelUpdate"
label = "Auto update model"
default = false
help = "Auto update model to latest version after model publish."
onTasks = [
    "rigging"
]

Which is a bit better to write 👍

And the asset document that has been applied would be like:

{
    "type": "asset",
    "name": "Foo",
    "data": {
        "label": "Foo",
        "assetOptions": {
            "rigAutoModelUpdate": {
                "value": false
            }
        },
        "tasks": [
            "rigging"
        ]
    }
}

davidlatwe · 2020-07-24T14:34:21Z

A note to self:
Need to pay attention on existing entries in assets like "startFrame" or "endFrame" (or "frameStart", "frameEnd"), since those may have been written into the asset document in existing production, so the landing opint of those assetOptions may not be able to like the example asset document above. 🤔

So to compat (able to edit in GUI) those existing options, new assetOptions may have to live directly under "data" field in asset document, like this:

{
    "type": "asset",
    "name": "Foo",
    "data": {
        "label": "Foo",
        "rigAutoModelUpdate": true,
        "tasks": [
            "rigging"
        ]
    }
}

{
    "type": "asset",
    "name": "shot01",
    "data": {
        "label": "shot 01",
        "frameStart": 100,
        "frameEnd": 200,
        "fps": 24,
        "tasks": [
            "rigging"
        ]
    }
}

And the existing "frameStart" for example, can be defined like:

[[assetOptions]]
name = "frameStart"
label = "Start frame"
default = 100
help = "The start frame of the shot."
onTasks = [
    "layout",
    "animating",
    "lighting"
]

BigRoy · 2020-07-24T15:46:34Z

new assetOptions may have to live directly under "data" field in asset document

Exactly what I was expecting yes. I imagined these new "rig specific settings" similar to an Asset/Shot specific setting like Resolution/FPS (if overridden from a project's default) or things like that.

Would love to know whether that would work for your use cases?

davidlatwe · 2020-07-24T15:53:42Z

Yeah, that would work in our case even better 🚀

See discussion on getavalon#556

So the new property "assetOptions" can be saved to database.

hound · 2020-07-25T14:54:03Z

avalon/tools/projectmanager/app.py

+            available_in_all_tasks = not specified_tasks
+
+            if (available_in_all_tasks
+                    or any(task in specified_tasks for task in task_names)):


line break before binary operator

hound · 2020-07-25T14:54:03Z

avalon/tools/projectmanager/app.py

@@ -1,18 +1,141 @@
 import sys

-from ...vendor.Qt import QtWidgets, QtCore
+from ...vendor.Qt import QtWidgets, QtCore, QtGui


'...vendor.Qt.QtGui' imported but unused

davidlatwe · 2020-07-25T14:57:13Z

I have refactored to adopt "assetOptions", but noted that the config-1.0 schema also need to be updated as well since "assetOptions" is a new property in project config.

Or should we make a config-1.1 schema ? Or config-2.0 ?

mkolar · 2020-07-26T21:06:16Z

Coming late to the party, but good to see what you guys agreed on at the end. It is a lot more flexible and easily expandable to many other types of parameters than the original concept.

davidlatwe · 2020-07-31T14:28:29Z

Or should we make a config-1.1 schema ? Or config-2.0 ?

I will add config-1.1, since it's a minor change.

BigRoy · 2020-09-21T08:44:58Z

What's the status on this? Anyone using this in production?

davidlatwe · 2020-09-21T18:24:04Z

Or should we make a config-1.1 schema ? Or config-2.0 ?

I will add config-1.1, since it's a minor change.

I think the last comment I wrote was the last piece but somehow I never finish it. 😮
But I did put this into our production branch.

rebeccaLinx and others added 9 commits July 24, 2020 20:45

Auto update model

55ad901

Revert

1ccc9c3

Extend io.find to allow passing other query options

765e8b5

Avoid KeyError when asset has no task options

a77ebc0

Change to use relative import

06b6014

Unhidden method

202e257

WIP: Refactoring

98f73e7

WIP: Finishing up

574fca8

Implemented asset task option read/write interface

0fdcd7e

davidlatwe requested review from tokejepsen, BigRoy and mkolar July 24, 2020 12:56

davidlatwe added 3 commits July 25, 2020 22:47

Fix missing import

3d7438d

Refactor to asset options

7ca03e9

See discussion on getavalon#556

Update config-1.0.json and inventory.py

b649b4c

So the new property "assetOptions" can be saved to database.

hound bot reviewed Jul 25, 2020

View reviewed changes

kalisp mentioned this pull request Sep 15, 2020

#180 - Enrich tasks with additional information ynput/OpenPype#516

Closed

kalisp mentioned this pull request Sep 29, 2020

Store task types in the database ynput/OpenPype#572

Merged

BigRoy changed the title ~~Asset task options impelementation~~ Asset task options implementation Sep 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Asset task options implementation #556

Asset task options implementation #556

davidlatwe commented Jul 24, 2020

tokejepsen commented Jul 24, 2020

davidlatwe commented Jul 24, 2020

davidlatwe commented Jul 24, 2020

tokejepsen commented Jul 24, 2020

BigRoy commented Jul 24, 2020

davidlatwe commented Jul 24, 2020 •

edited

Loading

davidlatwe commented Jul 24, 2020

davidlatwe commented Jul 24, 2020 •

edited

Loading

BigRoy commented Jul 24, 2020

davidlatwe commented Jul 24, 2020

hound bot Jul 25, 2020

hound bot Jul 25, 2020

davidlatwe commented Jul 25, 2020

mkolar commented Jul 26, 2020

davidlatwe commented Jul 31, 2020

BigRoy commented Sep 21, 2020

davidlatwe commented Sep 21, 2020 •

edited

Loading

Asset task options implementation #556

Are you sure you want to change the base?

Asset task options implementation #556

Conversation

davidlatwe commented Jul 24, 2020

Intooduce Asset Task Option

Setup

Usage

Notes

tokejepsen commented Jul 24, 2020

davidlatwe commented Jul 24, 2020

davidlatwe commented Jul 24, 2020

tokejepsen commented Jul 24, 2020

BigRoy commented Jul 24, 2020

davidlatwe commented Jul 24, 2020 • edited Loading

davidlatwe commented Jul 24, 2020

davidlatwe commented Jul 24, 2020 • edited Loading

BigRoy commented Jul 24, 2020

davidlatwe commented Jul 24, 2020

hound bot Jul 25, 2020

Choose a reason for hiding this comment

hound bot Jul 25, 2020

Choose a reason for hiding this comment

davidlatwe commented Jul 25, 2020

mkolar commented Jul 26, 2020

davidlatwe commented Jul 31, 2020

BigRoy commented Sep 21, 2020

davidlatwe commented Sep 21, 2020 • edited Loading

davidlatwe commented Jul 24, 2020 •

edited

Loading

davidlatwe commented Jul 24, 2020 •

edited

Loading

davidlatwe commented Sep 21, 2020 •

edited

Loading